KVM: x86: Bug the VM if the emulator accesses a non-existent GPR
authorSean Christopherson <seanjc@google.com>
Thu, 26 May 2022 21:08:15 +0000 (21:08 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 10 Jun 2022 14:01:33 +0000 (10:01 -0400)
commit1cca2f8c501fa01e6c0d2aefbf97f8c3c89c0186
tree318aa3d8ca38f3e3d790fba775332538b0d8adcd
parentb443183a25ab61840a12de92f8822849e017b9c8
KVM: x86: Bug the VM if the emulator accesses a non-existent GPR

Bug the VM, i.e. kill it, if the emulator accesses a non-existent GPR,
i.e. generates an out-of-bounds GPR index.  Continuing on all but
gaurantees some form of data corruption in the guest, e.g. even if KVM
were to redirect to a dummy register, KVM would be incorrectly read zeros
and drop writes.

Note, bugging the VM doesn't completely prevent data corruption, e.g. the
current round of emulation will complete before the vCPU bails out to
userspace.  But, the very act of killing the guest can also cause data
corruption, e.g. due to lack of file writeback before termination, so
taking on additional complexity to cleanly bail out of the emulator isn't
justified, the goal is purely to stem the bleeding and alert userspace
that something has gone horribly wrong, i.e. to avoid _silent_ data
corruption.

Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Message-Id: <20220526210817.3428868-7-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/emulate.c
arch/x86/kvm/kvm_emulate.h
arch/x86/kvm/x86.c