scsi: target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN
authorBodo Stroesser <bstroesser@ts.fujitsu.com>
Thu, 9 Apr 2020 10:10:26 +0000 (12:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 2 May 2020 06:48:56 +0000 (08:48 +0200)
commit1cc2460dad8274670da6aa42f6dfc7dbc3728f05
tree02d6faba60e0d03b95b0edd605efcd3266b9734e
parent62d350eb31d17a96528aba76ce23c806346d08cd
scsi: target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN

[ Upstream commit 066f79a5fd6d1b9a5cc57b5cd445b3e4bb68a5b2 ]

In case command ring buffer becomes inconsistent, tcmu sets device flag
TCMU_DEV_BIT_BROKEN.  If the bit is set, tcmu rejects new commands from LIO
core with TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE, and no longer processes
completions from the ring.  The reset_ring attribute can be used to
completely clean up the command ring, so after reset_ring the ring no
longer is inconsistent.

Therefore reset_ring also should reset bit TCMU_DEV_BIT_BROKEN to allow
normal processing.

Link: https://lore.kernel.org/r/20200409101026.17872-1-bstroesser@ts.fujitsu.com
Acked-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/target/target_core_user.c