Specify StringComparison.Ordinal in System.Diagnostics.Tracing
authorJustin Van Patten <jvp@justinvp.com>
Thu, 7 Jul 2016 01:43:56 +0000 (18:43 -0700)
committerJustin Van Patten <jvp@justinvp.com>
Thu, 7 Jul 2016 01:43:56 +0000 (18:43 -0700)
commit1cb168fda144af13d1613cc205320d8d13d7395c
treeac83673cf070c956342240db318672c7c7e1588a
parenta13e8c75510f3594d899ed274cf164081fb11a54
Specify StringComparison.Ordinal in System.Diagnostics.Tracing

The only uses of the default overloads of string.StartsWith, EndsWith,
and IndexOf that do not specify a StringComparison in
System.Private.CoreLib are in System.Diagnostics.Tracing. Right now,
this means these calls do a comparison using the current culture, but
I believe these can and should all be StringComparison.Ordinal.

Commit migrated from https://github.com/dotnet/coreclr/commit/179e30421b25de1d0e739c7c58dce711b0426791
src/coreclr/src/mscorlib/src/System/Diagnostics/Eventing/ActivityTracker.cs
src/coreclr/src/mscorlib/src/System/Diagnostics/Eventing/EventProvider.cs
src/coreclr/src/mscorlib/src/System/Diagnostics/Eventing/EventSource.cs
src/coreclr/src/mscorlib/src/System/Diagnostics/Eventing/TraceLogging/TraceLoggingEventSource.cs