mm: compaction: drop redundant watermark check in compaction_zonelist_suitable()
authorJohannes Weiner <hannes@cmpxchg.org>
Fri, 19 May 2023 12:39:59 +0000 (14:39 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 9 Jun 2023 23:25:37 +0000 (16:25 -0700)
commit1c9568e806a589da84b7afbdf0619b2c1f6c102a
treed47f0034585e8d06c3eeae164bfaa6055f3a812a
parentf98a497e1f16ee411df72629e32e31cba4cfa9cf
mm: compaction: drop redundant watermark check in compaction_zonelist_suitable()

The watermark check in compaction_zonelist_suitable(), called from
should_compact_retry(), is sandwiched between two watermark checks
already: before, there are freelist attempts as part of direct reclaim and
direct compaction; after, there is a last-minute freelist attempt in
__alloc_pages_may_oom().

The check in compaction_zonelist_suitable() isn't necessary. Kill it.

Link: https://lkml.kernel.org/r/20230519123959.77335-6-hannes@cmpxchg.org
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/compaction.c