net: bridge: Move extack-setting to br_multicast_new_port_group()
authorPetr Machata <petrm@nvidia.com>
Thu, 2 Feb 2023 17:59:21 +0000 (18:59 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Feb 2023 08:48:25 +0000 (08:48 +0000)
commit1c85b80b20a13d07ec3a7d746ad52b7972c8c730
tree1fa74a9c2cad4f738678d1d9b675fa791474e028
parent60977a0c63373bfc596b562b1e34e64ede6ef492
net: bridge: Move extack-setting to br_multicast_new_port_group()

Now that br_multicast_new_port_group() takes an extack argument, move
setting the extack there. The downside is that the error messages end
up being less specific (the function cannot distinguish between (S,G)
and (*,G) groups). However, the alternative is to check in the caller
whether the callee set the extack, and if it didn't, set it. But that
is only done when the callee is not exactly known. (E.g. in case of a
notifier invocation.)

Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_mdb.c
net/bridge/br_multicast.c