irqchip/mmp: Only touch the PJ4 IRQ & FIQ bits on enable/disable
authorLubomir Rintel <lkundrak@v3.sk>
Mon, 28 Jan 2019 15:59:35 +0000 (16:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Mar 2019 21:02:35 +0000 (14:02 -0700)
commit1bf791023315b4ad05dc1c7d94294ba7a39ed083
treef65ec2490e9bd94c5245d9f3ffc75f0050230bf4
parent423869f8871dee4028b67fa30f660ab43d14cfb2
irqchip/mmp: Only touch the PJ4 IRQ & FIQ bits on enable/disable

[ Upstream commit 2380a22b60ce6f995eac806e69c66e397b59d045 ]

Resetting bit 4 disables the interrupt delivery to the "secure
processor" core. This breaks the keyboard on a OLPC XO 1.75 laptop,
where the firmware running on the "secure processor" bit-bangs the
PS/2 protocol over the GPIO lines.

It is not clear what the rest of the bits are and Marvell was unhelpful
when asked for documentation. Aside from the SP bit, there are probably
priority bits.

Leaving the unknown bits as the firmware set them up seems to be a wiser
course of action compared to just turning them off.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Pavel Machek <pavel@ucw.cz>
[maz: fixed-up subject and commit message]
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-mmp.c