nvmet-auth: don't try to cancel a non-initialized work_struct
authorChristoph Hellwig <hch@lst.de>
Tue, 20 Sep 2022 13:37:18 +0000 (15:37 +0200)
committerChristoph Hellwig <hch@lst.de>
Tue, 27 Sep 2022 07:22:09 +0000 (09:22 +0200)
commit1befd944e05050d76950014f3dc04ed47faba2c3
tree1524442d9f75fbab5a8c6135d35c6f980ca39c9e
parent0700542a823ba3d3aa9c699a255aecc23dbbcaff
nvmet-auth: don't try to cancel a non-initialized work_struct

Currently blktests nvme/002 trips up debugobjects if CONFIG_NVME_AUTH is
enabled, but authentication is not on a queue.  This is because
nvmet_auth_sq_free cancels sq->auth_expired_work unconditionaly, while
auth_expired_work is only ever initialized if authentication is enabled
for a given controller.

Fix this by calling most of what is nvmet_init_auth unconditionally
when initializing the SQ, and just do the setting of the result
field in the connect command handler.

Fixes: db1312dd9548 ("nvmet: implement basic In-Band Authentication")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@suse.de>
drivers/nvme/target/core.c
drivers/nvme/target/fabrics-cmd-auth.c
drivers/nvme/target/fabrics-cmd.c
drivers/nvme/target/nvmet.h