[gn build] Make libcxx_enable_debug_mode work better, maybe
authorNico Weber <thakis@chromium.org>
Tue, 15 Nov 2022 15:40:34 +0000 (10:40 -0500)
committerNico Weber <thakis@chromium.org>
Tue, 15 Nov 2022 15:45:41 +0000 (10:45 -0500)
commit1b829c3d3a8c0488f8aa553eb15c7ee658f491c9
tree5a12a669ad5ea7cee6a34378f665b0738e4ae9c6
parent452a14efc84edf808d1e2953dad2c694972b312f
[gn build] Make libcxx_enable_debug_mode work better, maybe

Refer to _LIBCPP_ENABLE_DEBUG_MODE instead of the old _LIBCPP_DEBUG
in a comment, and write that to __config_site correctly too.

See 13ea1343231fa4 and the comments in https://crbug.com/1358646.

Also change the default of libcxx_enable_debug_mode to false for now.
Since we used to not write _LIBCPP_ENABLE_DEBUG_MODE, the previous
default of true had no effect (except for compiling debug.cpp and
legacy_debug_handler.cpp, which we now no longer build by default).
So this (mostly) preserves previous behavior.
llvm/utils/gn/secondary/libcxx/config.gni
llvm/utils/gn/secondary/libcxx/include/BUILD.gn
llvm/utils/gn/secondary/libcxx/src/BUILD.gn