crypto: x86/curve25519 - fix cpu feature checking logic in mod_exit
authorHangbin Liu <liuhangbin@gmail.com>
Thu, 3 Jun 2021 05:53:40 +0000 (01:53 -0400)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 11 Jun 2021 07:03:29 +0000 (15:03 +0800)
commit1b82435d17774f3eaab35dce239d354548aa9da2
tree4121f811a7434a292843e62453ee7ddd4f145bb8
parenta8bc4f5e7a72e4067f5afd7e98b61624231713ca
crypto: x86/curve25519 - fix cpu feature checking logic in mod_exit

In curve25519_mod_init() the curve25519_alg will be registered only when
(X86_FEATURE_BMI2 && X86_FEATURE_ADX). But in curve25519_mod_exit()
it still checks (X86_FEATURE_BMI2 || X86_FEATURE_ADX) when do crypto
unregister. This will trigger a BUG_ON in crypto_unregister_alg() as
alg->cra_refcnt is 0 if the cpu only supports one of X86_FEATURE_BMI2
and X86_FEATURE_ADX.

Fixes: 07b586fe0662 ("crypto: x86/curve25519 - replace with formally verified implementation")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/x86/crypto/curve25519-x86_64.c