ASoC: sof_es8336: fix possible use-after-free in sof_es8336_remove()
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 5 Dec 2022 14:37:21 +0000 (22:37 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 5 Dec 2022 17:29:36 +0000 (17:29 +0000)
commit1b41beaa7a58467505ec3023af8aad74f878b888
treefcd77f3297bcfd2b58636cade9c9ae15945326ee
parent9472382db38452df15f9f2f74b1dff34848e56b2
ASoC: sof_es8336: fix possible use-after-free in sof_es8336_remove()

sof_es8336_remove() calls cancel_delayed_work(). However, that
function does not wait until the work function finishes. This
means that the callback function may still be running after
the driver's remove function has finished, which would result
in a use-after-free.

Fix by calling cancel_delayed_work_sync(), which ensures that
the work is properly cancelled, no longer running, and unable
to re-schedule itself.

Fixes: 89cdb224f2ab ("ASoC: sof_es8336: reduce pop noise on speaker")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20221205143721.3988988-1-yangyingliang@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/sof_es8336.c