mm/vmalloc: invoke classify_va_fit_type() in adjust_va_to_fit_type()
authorBaoquan He <bhe@redhat.com>
Tue, 7 Jun 2022 10:59:55 +0000 (18:59 +0800)
committerakpm <akpm@linux-foundation.org>
Fri, 17 Jun 2022 02:48:28 +0000 (19:48 -0700)
commit1b23ff80b399ae4561bbfd45f7c9c98f62797304
tree27e79e422fba15a9c5b43558513965657fb16787
parentbcc728eb4f446073e0160671d7d0059a4e9aa300
mm/vmalloc: invoke classify_va_fit_type() in adjust_va_to_fit_type()

Patch series "Cleanup patches of vmalloc", v2.

Some cleanup patches found when reading vmalloc code.

This patch (of 4):

adjust_va_to_fit_type() checks all values of passed in fit type, including
NOTHING_FIT in the else branch.  However, the check of NOTHING_FIT has
been done inside adjust_va_to_fit_type() and before it's called in all
call sites.

In fact, both of these functions are coupled tightly, since
classify_va_fit_type() is doing the preparation work for
adjust_va_to_fit_type().  So putting invocation of classify_va_fit_type()
inside adjust_va_to_fit_type() can simplify code logic and the redundant
check of NOTHING_FIT issue will go away.

Link: https://lkml.kernel.org/r/20220607105958.382076-1-bhe@redhat.com
Link: https://lkml.kernel.org/r/20220607105958.382076-2-bhe@redhat.com
Signed-off-by: Baoquan He <bhe@redhat.com>
Suggested-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/vmalloc.c