Add a static assertions for custom Op<> to not defined data members (NFC)
authorMehdi Amini <joker.eph@gmail.com>
Tue, 8 Jun 2021 18:28:39 +0000 (18:28 +0000)
committerMehdi Amini <joker.eph@gmail.com>
Wed, 9 Jun 2021 21:45:06 +0000 (21:45 +0000)
commit1b21e9c1fa990a303fa5a543c17a5f470a32e112
tree433e8c6c0585fe9c0ad70773c9d46692b53cd926
parentb65f30d6fb6f5333dcb7c51f81c4309704c26f1f
Add a static assertions for custom Op<> to not defined data members (NFC)

A common mistake for newcomers to MLIR is to try to store extra member
on the Op class. However these are intended to be thing wrapper around
an Operation*, all the storage is meant to be encoded in attribute on
the underlying Operation. This can be confusing to debug, so better
catch it at build time.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D103869
mlir/include/mlir/IR/OpDefinition.h