vhost: synchronize IOTLB message with dev cleanup
authorJason Wang <jasowang@redhat.com>
Tue, 22 May 2018 11:58:57 +0000 (19:58 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 25 May 2018 02:09:51 +0000 (22:09 -0400)
commit1b15ad683ab42a203f98b67045b40720e99d0e9a
tree5f9f1adbe56a008b152ffcf9fa86aa3041986b0b
parentd681bc027a133f5c19e037f1bd3a142cffc566b4
vhost: synchronize IOTLB message with dev cleanup

DaeRyong Jeong reports a race between vhost_dev_cleanup() and
vhost_process_iotlb_msg():

Thread interleaving:
CPU0 (vhost_process_iotlb_msg) CPU1 (vhost_dev_cleanup)
(In the case of both VHOST_IOTLB_UPDATE and
VHOST_IOTLB_INVALIDATE)

===== =====
vhost_umem_clean(dev->iotlb);
if (!dev->iotlb) {
        ret = -EFAULT;
        break;
}
dev->iotlb = NULL;

The reason is we don't synchronize between them, fixing by protecting
vhost_process_iotlb_msg() with dev mutex.

Reported-by: DaeRyong Jeong <threeearcat@gmail.com>
Fixes: 6b1e6cc7855b0 ("vhost: new device IOTLB API")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/vhost/vhost.c