security: declare member holding string literal const
authorChristian Göttsche <cgzones@googlemail.com>
Thu, 17 Feb 2022 14:18:57 +0000 (15:18 +0100)
committerPaul Moore <paul@paul-moore.com>
Fri, 13 May 2022 18:51:06 +0000 (14:51 -0400)
commit1af0e4a0233fea7e8226cb977d379dc20f9bbe11
treeb8f66a9f9847db2187757f50ae0c999b09e8caae
parentc29722fad4aabbf6bb841b8f058f858ec911df56
security: declare member holding string literal const

The struct security_hook_list member lsm is assigned in
security_add_hooks() with string literals passed from the individual
security modules.  Declare the function parameter and the struct member
const to signal their immutability.

Reported by Clang [-Wwrite-strings]:

    security/selinux/hooks.c:7388:63: error: passing 'const char [8]'
      to parameter of type 'char *' discards qualifiers
      [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
            security_add_hooks(selinux_hooks,
                               ARRAY_SIZE(selinux_hooks), selinux);
                                                          ^~~~~~~~~
    ./include/linux/lsm_hooks.h:1629:11: note: passing argument to
      parameter 'lsm' here
                                    char *lsm);
                                          ^

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Reviewed-by: Paul Moore <paul@paul-moore.com>
Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
include/linux/lsm_hooks.h
security/security.c