ax25: NPD bug when detaching AX25 device
authorLin Ma <linma@zju.edu.cn>
Fri, 17 Dec 2021 02:29:41 +0000 (10:29 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 18 Dec 2021 12:33:56 +0000 (12:33 +0000)
commit1ade48d0c27d5da1ccf4b583d8c5fc8b534a3ac8
treebdda352fb3d827b8c2e45cda6f3e332301017f4c
parentb2f37aead1b82a770c48b5d583f35ec22aabb61e
ax25: NPD bug when detaching AX25 device

The existing cleanup routine implementation is not well synchronized
with the syscall routine. When a device is detaching, below race could
occur.

static int ax25_sendmsg(...) {
  ...
  lock_sock()
  ax25 = sk_to_ax25(sk);
  if (ax25->ax25_dev == NULL) // CHECK
  ...
  ax25_queue_xmit(skb, ax25->ax25_dev->dev); // USE
  ...
}

static void ax25_kill_by_device(...) {
  ...
  if (s->ax25_dev == ax25_dev) {
    s->ax25_dev = NULL;
    ...
}

Other syscall functions like ax25_getsockopt, ax25_getname,
ax25_info_show also suffer from similar races. To fix them, this patch
introduce lock_sock() into ax25_kill_by_device in order to guarantee
that the nullify action in cleanup routine cannot proceed when another
socket request is pending.

Signed-off-by: Hanjie Wu <nagi@zju.edu.cn>
Signed-off-by: Lin Ma <linma@zju.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ax25/af_ax25.c