media: pvrusb2: fix the retry logic
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 26 Jun 2017 12:33:56 +0000 (08:33 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Thu, 20 Jul 2017 20:25:41 +0000 (16:25 -0400)
commit1ad371deb9b0be142dca205611a56854a37fc48d
tree096d5557af2c8b08fc93269fd011766658927c01
parentf3b38dcaa4768f13c7009267b7eef1c94298e9a2
media: pvrusb2: fix the retry logic

As reported by this warning:
drivers/media/usb/pvrusb2/pvrusb2-encoder.c:263 pvr2_encoder_cmd() warn: continue to end of do { ... } while(0); loop

There's an issue at the retry logic there: the current logic is:

do {
if (need_to_retry)
continue;

some_code();
} while (0);

Well, that won't work, as continue will make it test for zero, and
abort the loop. So, change the loop to:

while (1) {
if (need_to_retry)
continue;

some_code();
break;
};

With seems to be what's actually expected there.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/pvrusb2/pvrusb2-encoder.c