remove the isatty() call so it's easier to audit the helper
authorDavid Zeuthen <davidz@redhat.com>
Mon, 30 Jul 2007 23:08:58 +0000 (19:08 -0400)
committerDavid Zeuthen <davidz@redhat.com>
Mon, 30 Jul 2007 23:08:58 +0000 (19:08 -0400)
commit1ac3268b7a787d2a9ae641355b80b7f3131bea71
treee76005d12f9220b615775ed80c286670684679d4
parent368397f96a472bfedd596c8890586cc4fd9a0428
remove the isatty() call so it's easier to audit the helper

The isatty() check is just to catch users poking around; it provides little or no real security. With this change, you can do stuff like

$ /usr/libexec/polkit-grant-helper-pam
davidz
PAM_PROMPT_ECHO_OFF Password:
<enter real password here>
SUCCESS

$ /usr/libexec/polkit-grant-helper-pam
davidz
PAM_PROMPT_ECHO_OFF Password:
not_my_password
polkit-grant-helper-pam: pam_authenticated failed: Authentication failure
FAILURE

which is useful for auditing.
polkit-grant/polkit-grant-helper-pam.c