gfs2: Fix use-after-free in gfs2_glock_shrink_scan
authorHillf Danton <hdanton@sina.com>
Tue, 18 May 2021 08:46:25 +0000 (16:46 +0800)
committerAndreas Gruenbacher <agruenba@redhat.com>
Mon, 31 May 2021 10:03:28 +0000 (12:03 +0200)
commit1ab19c5de4c537ec0d9b21020395a5b5a6c059b2
tree7fa57e0effbb461e2b36f5e1b6e54ef51daf6089
parentb7f55d928e75557295c1ac280c291b738905b6fb
gfs2: Fix use-after-free in gfs2_glock_shrink_scan

The GLF_LRU flag is checked under lru_lock in gfs2_glock_remove_from_lru() to
remove the glock from the lru list in __gfs2_glock_put().

On the shrink scan path, the same flag is cleared under lru_lock but because
of cond_resched_lock(&lru_lock) in gfs2_dispose_glock_lru(), progress on the
put side can be made without deleting the glock from the lru list.

Keep GLF_LRU across the race window opened by cond_resched_lock(&lru_lock) to
ensure correct behavior on both sides - clear GLF_LRU after list_del under
lru_lock.

Reported-by: syzbot <syzbot+34ba7ddbf3021981a228@syzkaller.appspotmail.com>
Signed-off-by: Hillf Danton <hdanton@sina.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/glock.c