Revert F16C series (MR 6774)
authorMatt Turner <mattst88@gmail.com>
Thu, 1 Oct 2020 20:48:16 +0000 (13:48 -0700)
committerMarge Bot <eric+marge@anholt.net>
Thu, 1 Oct 2020 21:08:12 +0000 (21:08 +0000)
commit1aac47db69d5cf40329ccd26acfea8f615db3415
treec5a551d14ec3d3b7acff4d4279b44d1615d9aafb
parent4a0164ed85f309ad4909bb481f16d5d4f8337181
Revert F16C series (MR 6774)

This reverts commit 4fb2eddfdf9adafde2e6f94de23202ee44123d59.
This reverts commit 7a1deb16f8af4e0ae4ed64511cbfcc606087f0ee.
This reverts commit 2b6a17234376817e75d1f81edf5bd1b28eefb374.
This reverts commit 5af81393e419eaf086e4de2a1d149af78cd1f54d.
This reverts commit 87900afe5bbe90c5f3ad0921b28ae1c889029ada.

A couple of problems were discovered after this series was merged that
cause breakage in different configurations:

   (1) It seems that using -mf16c also enables AVX, leading to SIGILL on
   platforms that do not support AVX.
   (2) Since clang only warns about unknown flags, and as I understand
   it Meson's handling in cc.has_argument() is broken, the F16C code is
   wrongly enabled when clang is used, even for example on ARM, leading
   to a compilation error.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3583
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6969>
45 files changed:
.gitlab-ci/piglit/quick_gl.txt
meson.build
src/amd/vulkan/radv_formats.c
src/freedreno/fdl/fd5_layout_test.c
src/freedreno/perfcntrs/fd2_perfcntr.c
src/freedreno/perfcntrs/fd5_perfcntr.c
src/freedreno/perfcntrs/fd6_perfcntr.c
src/freedreno/perfcntrs/freedreno_perfcntr.h
src/freedreno/registers/gen_header.py
src/freedreno/rnn/headergen2.c
src/freedreno/vulkan/tu_clear_blit.c
src/gallium/auxiliary/Makefile.sources
src/gallium/auxiliary/gallivm/lp_bld_const.c
src/gallium/auxiliary/gallivm/lp_bld_conv.c
src/gallium/auxiliary/meson.build
src/gallium/auxiliary/tgsi/tgsi_exec.c
src/gallium/auxiliary/translate/translate_generic.c
src/gallium/auxiliary/util/u_half.h [new file with mode: 0644]
src/gallium/drivers/etnaviv/etnaviv_blend.c
src/gallium/drivers/etnaviv/etnaviv_compiler_nir.c
src/gallium/drivers/etnaviv/etnaviv_disasm.c
src/gallium/drivers/etnaviv/etnaviv_zsa.c
src/gallium/drivers/freedreno/a5xx/fd5_emit.c
src/gallium/drivers/freedreno/a6xx/fd6_emit.c
src/gallium/drivers/freedreno/freedreno_texture.c
src/gallium/drivers/freedreno/freedreno_util.h
src/gallium/drivers/lima/ir/pp/codegen.c
src/gallium/drivers/lima/ir/pp/disasm.c
src/gallium/drivers/lima/lima_draw.c
src/gallium/drivers/nouveau/nv30/nv30_state_validate.c
src/gallium/drivers/r300/r300_blit.c
src/gallium/drivers/r300/r300_state.c
src/gallium/drivers/v3d/v3dx_emit.c
src/gallium/drivers/v3d/v3dx_state.c
src/gallium/frontends/nine/vertexshader9.h
src/gallium/tests/unit/translate_test.c
src/gallium/tests/unit/u_half_test.c
src/mesa/vbo/vbo_attrib_tmp.h
src/util/format/u_format_pack.py
src/util/format/u_format_tests.c
src/util/half_float.c
src/util/half_float.h
src/util/softfloat.c
src/util/softfloat.h
src/util/tests/format/u_format_test.c