net: ping: dont call udp_ioctl()
authorEric Dumazet <eric.dumazet@gmail.com>
Sun, 15 May 2011 21:26:31 +0000 (21:26 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 May 2011 15:49:39 +0000 (11:49 -0400)
commit1a8218e96271790a07dd7065a2ef173e0f67e328
tree3bf2696f434e21c92809b4812fa34b57061ce783
parent534ea99b063de7c30262a8e22f0ab44dd7d11a71
net: ping: dont call udp_ioctl()

udp_ioctl() really handles UDP and UDPLite protocols.

1) It can increment UDP_MIB_INERRORS in case first_packet_length() finds
a frame with bad checksum.

2) It has a dependency on sizeof(struct udphdr), not applicable to
ICMP/PING

If ping sockets need to handle SIOCINQ/SIOCOUTQ ioctl, this should be
done differently.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Vasiliy Kulikov <segoon@openwall.com>
Acked-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ping.c