kthread: Move prio/affinite change into the newly created thread
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tue, 10 Nov 2020 11:38:47 +0000 (12:38 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 5 Oct 2021 13:51:58 +0000 (15:51 +0200)
commit1a7243ca4074beed97b68d7235a6e34862fc2cd6
tree82c415b119e9d0d15584fe7687bbac31d77604d0
parentc597bfddc9e9e8a63817252b67c3ca0e544ace26
kthread: Move prio/affinite change into the newly created thread

With enabled threaded interrupts the nouveau driver reported the
following:

| Chain exists of:
|   &mm->mmap_lock#2 --> &device->mutex --> &cpuset_rwsem
|
|  Possible unsafe locking scenario:
|
|        CPU0                    CPU1
|        ----                    ----
|   lock(&cpuset_rwsem);
|                                lock(&device->mutex);
|                                lock(&cpuset_rwsem);
|   lock(&mm->mmap_lock#2);

The device->mutex is nvkm_device::mutex.

Unblocking the lockchain at `cpuset_rwsem' is probably the easiest
thing to do.  Move the priority reset to the start of the newly
created thread.

Fixes: 710da3c8ea7df ("sched/core: Prevent race condition between cpuset and __sched_setscheduler()")
Reported-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/a23a826af7c108ea5651e73b8fbae5e653f16e86.camel@gmx.de
kernel/kthread.c