can: fix loss of CAN frames in raw_rcv
authorOliver Hartkopp <socketcan@hartkopp.net>
Sun, 21 Jun 2015 16:50:44 +0000 (18:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jul 2015 16:49:27 +0000 (09:49 -0700)
commit1a2cddd17ebe5e76a796c25e11cdd5518310eabc
treeb582ac7cd209159054f37f952427cf2264cd5543
parentaa0b8c72f5c1e0208bfafb383b535bdc9d3b2c6b
can: fix loss of CAN frames in raw_rcv

commit 36c01245eb8046c16eee6431e7dbfbb302635fa8 upstream.

As reported by Manfred Schlaegl here

   http://marc.info/?l=linux-netdev&m=143482089824232&w=2

commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for
overlapping CAN filters" requires the skb->tstamp to be set to check for
identical CAN skbs.

As net timestamping is influenced by several players (netstamp_needed and
netdev_tstamp_prequeue) Manfred missed a proper timestamp which leads to
CAN frame loss.

As skb timestamping became now mandatory for CAN related skbs this patch
makes sure that received CAN skbs always have a proper timestamp set.
Maybe there's a better solution in the future but this patch fixes the
CAN frame loss so far.

Reported-by: Manfred Schlaegl <manfred.schlaegl@gmx.at>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/dev.c
drivers/net/can/slcan.c
drivers/net/can/vcan.c
net/can/af_can.c