Abstract deprecated and selectany for GCC and remove LLVM'ism where possible (#22662)
authorSinan Kaya <41809318+franksinankaya@users.noreply.github.com>
Wed, 20 Feb 2019 16:59:22 +0000 (11:59 -0500)
committerJan Kotas <jkotas@microsoft.com>
Wed, 20 Feb 2019 16:59:22 +0000 (08:59 -0800)
commit1a1bb292ab53c0c30d35dc396c7089c1da5b3c82
treebd590b373c55ad23997b9cdd3979951479d5beaf
parent3c2e989c61c7466bc6d061e03277dbbd8a7e54e9
Abstract deprecated and selectany for GCC and remove LLVM'ism where possible (#22662)

* Abstract selectany

* Fix initializer element is not constant

src/corefx/System.Globalization.Native/pal_icushim.c:58:34: error: initializer element is not constant
 static const int MaxICUVersion = MinICUVersion + 20;

* Enable ms extensions

* Apply LLVM patterns to GCC

* Remove deprecated function

* Fix const conversion error

src/corefx/System.Globalization.Native/pal_calendarData.c:390:16: warning: passing argument 1 of ‘ures_close_ptr’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
ures_close(erasResBundle);

src/corefx/System.Globalization.Native/pal_calendarData.c:419:22: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
char* name = GetCalendarName(calendarId);

* Remove old compiler option
12 files changed:
configurecompiler.cmake
src/corefx/System.Globalization.Native/CMakeLists.txt
src/corefx/System.Globalization.Native/pal_calendarData.c
src/corefx/System.Globalization.Native/pal_icushim.c
src/inc/cor.h
src/inc/corinfo.h
src/inc/holder.h
src/inc/palclr.h
src/pal/inc/pal.h
src/scripts/genEtwProvider.py
src/vm/appdomain.cpp
src/vm/appdomain.hpp