mmc: sh_mmcif: don't clear masked interrupts
authorGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Wed, 15 May 2013 05:50:51 +0000 (07:50 +0200)
committerChris Ball <cjb@laptop.org>
Thu, 6 Jun 2013 11:40:48 +0000 (07:40 -0400)
commit19f1ba51c79f133aec3ce558b8292e3b081363f3
tree536e66c0b06118c6ab4f4dcd485bdb302c3b5167
parentb22ffdcd25d67a07f2b5a75a7805826bfe8597f1
mmc: sh_mmcif: don't clear masked interrupts

Masking events on MMCIF means that an occurrence of the masked event
won't raise an interrupt, but the event bit will still be set in the
interrupt status register. If simultaneously a different event occurs
which was enabled, both flags will be set. However, only the unmasked
event bit should be cleared in the status register in such a case.

Clearing also the masked bit can lead to lost interrupts, which indeed
can be observed on the armadillo800eva r8a7740 board with an eMMC chip.
The problem has been introduced by the recent "mmc: sh_mmcif: simplify
IRQ processing" patch. Fix the problem by only clearing enabled interrupts.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
Tested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/host/sh_mmcif.c