Fix overflow checking for 32-bit pc-relative relocations on x32.
authorCary Coutant <ccoutant@gmail.com>
Sat, 6 Feb 2016 22:47:05 +0000 (14:47 -0800)
committerCary Coutant <ccoutant@gmail.com>
Sat, 6 Feb 2016 22:47:05 +0000 (14:47 -0800)
commit19ef3f4d2eaac10e98c7ba3f9eace8609ab5278e
treef759db3d5c30cc937c6bf904c5b5e200f9350d45
parent72c55146bb505642994637071b305bf4d30ef685
Fix overflow checking for 32-bit pc-relative relocations on x32.

The problem here is that x32 is really using 64-bit addressing,
while pretending to be 32-bit. Even though the object file format
is 32-bit, we need to do the overflow checking with 64-bit
arithmetic (because that's what the hardware will be using).
This patch overrides the pcrela32_check functions in reloc.h
with target-specific versions that do 64-bit checking.

I've also updated the test case to use -Tdata instead of adding
a huge .space directive, to reduce the size of the .o files.

gold/
PR gold/19567
* reloc.h (Relocate_functions::Overflow_check): Add comments.
* x86_64.cc (X86_64_relocate_functions): New class.
(Target_x86_64::Relocate::relocate): Use the new class.
* testsuite/Makefile.am (x86_64_overflow_pc32): Add -Tdata option.
(x32_overflow_pc32): New test case.
* testsuite/Makefile.in: Regenerate.
* testsuite/x32_overflow_pc32.sh: New script.
* testsuite/x86_64_overflow_pc32.s: Remove .space directive.
gold/ChangeLog
gold/reloc.h
gold/testsuite/Makefile.am
gold/testsuite/Makefile.in
gold/testsuite/x32_overflow_pc32.sh [new file with mode: 0755]
gold/testsuite/x86_64_overflow_pc32.s
gold/x86_64.cc