Revert "ext4: remove unnecessary check in ext4_bg_num_gdb_nometa"
authorKemeng Shi <shikemeng@huaweicloud.com>
Tue, 13 Jun 2023 22:50:25 +0000 (06:50 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 15 Jun 2023 02:22:27 +0000 (22:22 -0400)
commit19482792113fa1dc419f9bc7b04b9dbdaa5256fd
tree5d107f097890ce121ba3a04fee806d5c09964d70
parentdea9d8f7643fab07bf89a1155f1f94f37d096a5e
Revert "ext4: remove unnecessary check in ext4_bg_num_gdb_nometa"

This reverts commit ad3f09be6cfe332be8ff46c78e6ec0f8839107aa.

The reverted commit was intended to simpfy the code to get group
descriptor block number in non-meta block group by assuming
s_gdb_count is block number used for all non-meta block group descriptors.
However s_gdb_count is block number used for all meta *and* non-meta
group descriptors. So s_gdb_group will be > actual group descriptor block
number used for all non-meta block group which should be "total non-meta
block group" / "group descriptors per block", e.g. s_first_meta_bg.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Link: https://lore.kernel.org/r/20230613225025.3859522-1-shikemeng@huaweicloud.com
Fixes: ad3f09be6cfe ("ext4: remove unnecessary check in ext4_bg_num_gdb_nometa")
Cc: stable@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/balloc.c