egl/dri2: Stop disabling pbuffer support on msaa configs
authorAdam Jackson <ajax@redhat.com>
Tue, 3 Sep 2019 19:57:47 +0000 (15:57 -0400)
committerMarge Bot <eric+marge@anholt.net>
Fri, 23 Jul 2021 19:22:44 +0000 (19:22 +0000)
commit18e7633b384cc51467bf7eaa725bf318c4d6c271
tree66d451f6e232e0ada8588895b531a6f130906078
parent0972b0f7547fe9956a1b5a5cbfda38a0fd996fa6
egl/dri2: Stop disabling pbuffer support on msaa configs

We started doing this in:

    commit 4d6d55deef291b489af4d7870c6f5eb223c8da5d
    Author: Tapani Pälli <tapani.palli@intel.com>
    Date:   Mon Sep 26 10:03:32 2016 +0300

        egl: stop claiming support for pbuffer + msaa

        This fixes a crash in egl-create-msaa-pbuffer-surface Piglit test
        and same crash in many dEQP EGL tests.

Whatever bug that was papering over appears to be fixed by now, I can
no longer reproduce that crash with piglit. Furthermore, disabling that
bit in the generic dri2 code had the side effect that the surfaceless
platform would advertise EGLConfigs with _no_ supported surface types
(since surfaceless only supports pbuffers).

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1859>
src/broadcom/ci/deqp-vc4-rpi3-fails.txt
src/egl/drivers/dri2/egl_dri2.c
src/gallium/drivers/llvmpipe/ci/llvmpipe-quick_gl.txt