RDMA/mlx4: Copy union directly
authorGustavo A. R. Silva <gustavoars@kernel.org>
Tue, 15 Aug 2023 20:39:53 +0000 (14:39 -0600)
committerLeon Romanovsky <leon@kernel.org>
Wed, 16 Aug 2023 06:28:33 +0000 (09:28 +0300)
commit18ddaeb03bdb65b84fece11a8cac5bf583ae1b91
tree0f7df9362e0893a8b3aef5eb2d2d9d5b035c3e4f
parent295c95aa7e0310ad8a89e98f1632d066e8526bb2
RDMA/mlx4: Copy union directly

Copy union directly instead of using memcpy().

Note that in this case, a direct assignment is more readable and
consistent with the subsequent assignments.

This addresses the following -Wstringop-overflow warning seen in s390
with defconfig:
drivers/infiniband/hw/mlx4/main.c:296:33: warning: writing 16 bytes into a region of size 0 [-Wstringop-overflow=]
  296 |                                 memcpy(&port_gid_table->gids[free].gid,
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  297 |                                        &attr->gid, sizeof(attr->gid));
      |                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This helps with the ongoing efforts to globally enable
-Wstringop-overflow.

Link: https://github.com/KSPP/linux/issues/308
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/ZNvimeRAPkJ24zRG@work
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/mlx4/main.c