sfc: Fix IRQ cleanup in case of a probe failure
authorBen Hutchings <bhutchings@solarflare.com>
Wed, 22 May 2013 17:03:35 +0000 (18:03 +0100)
committerBen Hutchings <bhutchings@solarflare.com>
Mon, 24 Jun 2013 19:02:52 +0000 (20:02 +0100)
commit1899c111a535e43046b14ae13639747d9d2544d6
tree588ba12d8ce0e35137575880b2901e11e97e9d58
parente79255de8581fac7c77dba443d5e79bbc6e72a1f
sfc: Fix IRQ cleanup in case of a probe failure

The lifetime of an irq_cpu_rmap is odd: we have to allocate it before
installing IRQ handlers and free it before removing the IRQ handlers.
As a result of this asymmetry, it was omitted from some failure paths.

On another failure path, we could try to remove IRQ handlers we
had not yet installed.

Move the irq_cpu_rmap allocation and freeing alongside IRQ handler
installation and removal, in efx_nic_{init,fini}_interrupts().
Count the number of IRQ handlers successfully installed and only
remove those on the failure path.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
drivers/net/ethernet/sfc/efx.c
drivers/net/ethernet/sfc/nic.c