bpf: Initialize storage pointers to NULL to prevent freeing garbage pointer
authorAndrii Nakryiko <andriin@fb.com>
Mon, 9 Mar 2020 22:27:55 +0000 (15:27 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Apr 2020 09:02:11 +0000 (11:02 +0200)
commit188aae1f3d5f155a05f5727f53884ffc4b12b1ca
tree4c5d68d6be18e729ce96ff192abb57ed4ee0593a
parentc68e1117f4e41db9b43e0eb800cdf343fe54a99e
bpf: Initialize storage pointers to NULL to prevent freeing garbage pointer

commit 62039c30c19dcab96621e074aeeb90da7100def7 upstream.

Local storage array isn't initialized, so if cgroup storage allocation fails
for BPF_CGROUP_STORAGE_SHARED, error handling code will attempt to free
uninitialized pointer for BPF_CGROUP_STORAGE_PERCPU storage type. Avoid this
by always initializing storage pointers to NULLs.

Fixes: 8bad74f9840f ("bpf: extend cgroup bpf core to allow multiple cgroup storage types")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200309222756.1018737-1-andriin@fb.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/bpf/cgroup.c