selinux: fix double free of cond_list on error paths
authorVratislav Bendel <vbendel@redhat.com>
Wed, 2 Feb 2022 11:25:11 +0000 (12:25 +0100)
committerPaul Moore <paul@paul-moore.com>
Wed, 2 Feb 2022 16:02:10 +0000 (11:02 -0500)
commit186edf7e368c40d06cf727a1ad14698ea67b74ad
tree138762ec92ee3a0a054d3809e235a90db82259d7
parente783362eb54cd99b2cac8b3a9aeac942e6f6ac07
selinux: fix double free of cond_list on error paths

On error path from cond_read_list() and duplicate_policydb_cond_list()
the cond_list_destroy() gets called a second time in caller functions,
resulting in NULL pointer deref.  Fix this by resetting the
cond_list_len to 0 in cond_list_destroy(), making subsequent calls a
noop.

Also consistently reset the cond_list pointer to NULL after freeing.

Cc: stable@vger.kernel.org
Signed-off-by: Vratislav Bendel <vbendel@redhat.com>
[PM: fix line lengths in the description]
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/ss/conditional.c