Provide upgrade response details (#71757)
authorKatya Sokolova <esokolov@microsoft.com>
Tue, 12 Jul 2022 23:59:15 +0000 (01:59 +0200)
committerGitHub <noreply@github.com>
Tue, 12 Jul 2022 23:59:15 +0000 (01:59 +0200)
commit1846c072facdc1f9e7b2615296d59ff007d23771
tree9d802856fde81ab4d6e554092de94eb1c1b12a24
parentca1a4d899054ac3d7c8140240caeed6edfda96da
Provide upgrade response details (#71757)

* Provide Upgrade response details

* fixing tests

* Address review feedback

* Save HttpStatusCode without CollectHttpResponseDetails

* Remove unnesessary skip on test

* Disable ConnectAsync_Failed on browser since CollectHttpResponseDetails is not supported

* Update src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs

Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
* Address review feedback

* Revert "Save HttpStatusCode without CollectHttpResponseDetails"

This reverts commit 0713bd8e292b6a76b0b9f297d95e466f11feff3b.

* renove using from ref

* Update test

* Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/ClientWebSocket.cs

Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
* fixing Values and Enumerator for HttpResponseHeaders

* fixing Values and Enumerator for HttpResponseHeaders

* Apply suggestions from code review

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
* Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/WebSocketHandle.Managed.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Apply suggestions from code review

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Check CollectHttpResponseDetails setter

* disable CA1822 // Mark members as static

Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
src/libraries/System.Net.WebSockets.Client/ref/System.Net.WebSockets.Client.cs
src/libraries/System.Net.WebSockets.Client/src/System.Net.WebSockets.Client.csproj
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/ClientWebSocketOptions.cs
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/ClientWebSocket.cs
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/ClientWebSocketOptions.cs
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/HttpResponseHeadersReadOnlyCollection.cs [new file with mode: 0644]
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/WebSocketHandle.Browser.cs
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/WebSocketHandle.Managed.cs
src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs