Improvements for naked R2RDump output (dotnet/coreclr#21317)
authorTomáš Rylek <trylek@microsoft.com>
Mon, 3 Dec 2018 19:33:49 +0000 (20:33 +0100)
committerGitHub <noreply@github.com>
Mon, 3 Dec 2018 19:33:49 +0000 (20:33 +0100)
commit183005cb391cf5d8bfa8a8f43055bd12309a6624
tree1e0ee491855d6a8fd5f3a93e8beb5d4ee65686b1
parent7daa2f1a07ba01a1da026e9e9b0b6386fbc6fdcd
Improvements for naked R2RDump output (dotnet/coreclr#21317)

The initial impulse for this change was removing native offsets
from debug info that caused noise in naked R2R comparisons. Fixing
this required propagation of DumpOptions to some more call sites
prompting me to unify dumping logic to always use TextWriter
as the output medium. I have also fixed some minor bugs I noticed
around the naked disassembly.

Thanks

Tomas

Commit migrated from https://github.com/dotnet/coreclr/commit/940ed217fd424f645227acd3d9fac0caf28ec47b
src/coreclr/src/tools/r2rdump/CoreDisTools.cs
src/coreclr/src/tools/r2rdump/DebugInfo.cs
src/coreclr/src/tools/r2rdump/EHInfo.cs
src/coreclr/src/tools/r2rdump/R2RMethod.cs
src/coreclr/src/tools/r2rdump/TextDumper.cs