projects / platform / upstream / dotnet / runtime.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ac78451) | patch
Honor converters for underlying types of Nullable<T> specified with JsonConverterAttr...
authorMikel Blanchard <mblanchard@macrosssoftware.com>
Sat, 29 Feb 2020 01:15:03 +0000 (17:15 -0800)
committerGitHub <noreply@github.com>
Sat, 29 Feb 2020 01:15:03 +0000 (17:15 -0800)
commit17e2caebc4c834840dbe1d99edfb2d58a8afa48a
tree00c4ab6d45bf24ce8e8bd4a3b96127ba241f1cd9tree | snapshot
parentac78451b9354f150b892bf1e4ffc1a86e2db848acommit | diff
Honor converters for underlying types of Nullable<T> specified with JsonConverterAttribute (#32006)

* FIxed exception being thrown when JsonConverterAttribute is used on Nullable<T> when converter can handle T.

* Expanded test coverage.

* Code review feedback.

* Code review feedback.

* Updated to use JsonValueConverterNullableFactory directly instead of fall-through logic.

* Null response is no longer possible.

* Code review.

* Updated for refactoring.

* Code review.

* Code review #2.
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/NullableConverterFactory.cs diff | blob | history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs diff | blob | history
src/libraries/System.Text.Json/tests/Serialization/CustomConverterTests.NullableTypes.cs [new file with mode: 0644] blob
src/libraries/System.Text.Json/tests/System.Text.Json.Tests.csproj diff | blob | history
Domain: Dotnet / Core;