perf/x86/intel/uncore: Fix reference count leak in __uncore_imc_init_box()
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Fri, 18 Nov 2022 06:31:37 +0000 (14:31 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 24 Nov 2022 10:09:26 +0000 (11:09 +0100)
commit17b8d847b92d815d1638f0de154654081d66b281
tree18bfef68e70687bdd5f582a3426b5e1a43111861
parent8ebd16c11c346751b3944d708e6c181ed4746c39
perf/x86/intel/uncore: Fix reference count leak in __uncore_imc_init_box()

pci_get_device() will increase the reference count for the returned
pci_dev, so tgl_uncore_get_mc_dev() will return a pci_dev with its
reference count increased. We need to call pci_dev_put() to decrease the
reference count before exiting from __uncore_imc_init_box(). Add
pci_dev_put() for both normal and error path.

Fixes: fdb64822443e ("perf/x86: Add Intel Tiger Lake uncore support")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Link: https://lore.kernel.org/r/20221118063137.121512-5-wangxiongfeng2@huawei.com
arch/x86/events/intel/uncore_snb.c