[llvm-objcopy] If input=output, preserve umask bits, otherwise drop S_ISUID/S_ISGID...
authorFangrui Song <i@maskray.me>
Wed, 24 Feb 2021 19:10:09 +0000 (11:10 -0800)
committerFangrui Song <i@maskray.me>
Wed, 24 Feb 2021 19:10:09 +0000 (11:10 -0800)
commit17b4e695ce0ef89eac4a37df2df49d4c0e700766
treeb28da788404c534ec03ef8d5f880e811d90a0318
parentc2487bf7dfdda59b775b3d5a06684af243790125
[llvm-objcopy] If input=output, preserve umask bits, otherwise drop S_ISUID/S_ISGID bits

This makes the behavior similar to cp

```
chmod u+s,g+s,o+x a
sudo llvm-strip a -o b
// With this patch, b drops set-user-ID and set-group-ID bits.
// sudo cp a b => b does not have set-user-ID or set-group-ID bits.
```

This also changes the behavior for the following case:

```
chmod u+s,g+s,o+x a
llvm-strip a
// a preserves set-user-ID and set-group-ID bits.
// This matches binutils<2.36 and probably >=2.37.  2.36 and 2.36.1 have some compatibility issues.
```

Differential Revision: https://reviews.llvm.org/D97253
llvm/test/tools/llvm-objcopy/ELF/mirror-permissions-unix.test
llvm/tools/llvm-objcopy/llvm-objcopy.cpp