Input: elantech - improve clickpad detection
authorHans de Goede <hdegoede@redhat.com>
Mon, 16 Dec 2013 15:09:25 +0000 (07:09 -0800)
committerJiri Slaby <jslaby@suse.cz>
Mon, 31 Mar 2014 12:22:32 +0000 (14:22 +0200)
commit1743fc6cc6a54a4fac440ce885752cee819ed25a
tree94f184f769c9b7b4a2966d5e704d9f7afaa75e49
parent6d05cdce4fb86af309b91cc1e055e995f79c9a72
Input: elantech - improve clickpad detection

commit c15bdfd5b9831e4cab8cfc118243956e267dd30e upstream.

The current assumption in the elantech driver that hw version 3 touchpads
are never clickpads and hw version 4 touchpads are always clickpads is
wrong.

There are several bug reports for this, ie:
https://bugzilla.redhat.com/show_bug.cgi?id=1030802
http://superuser.com/questions/619582/right-elantech-touchpad-button-not-working-in-linux

I've spend a couple of hours wading through various bugzillas, launchpads
and forum posts to create a list of fw-versions and capabilities for
different laptop models to find a good method to differentiate between
clickpads and versions with separate hardware buttons.

Which shows that a device being a clickpad is reliable indicated by bit 12
being set in the fw_version. I've included the gathered list inside the
driver, so that we've this info at hand if we need to revisit this later.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Josh Boyer <jwboyer@fedoraproject.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/input/mouse/elantech.c