Reapply [LLDB] [test] Use %clang_cl instead of build.py in a few tests
authorMartin Storsjö <martin@martin.st>
Wed, 16 Oct 2019 12:11:50 +0000 (15:11 +0300)
committerMartin Storsjö <martin@martin.st>
Fri, 1 Nov 2019 18:49:13 +0000 (20:49 +0200)
commit1739c7c10c42748c278b0ea194e32bbfdd04fb98
treef5ebcd7a2c9e0f19147034bd454ed9efa9a89fc1
parent309f9a1c52977cbd011b29909f7aa45c124b005f
Reapply [LLDB] [test] Use %clang_cl instead of build.py in a few tests

This allows explicitly specifying the intended target architecture,
for tests that aren't supposed to be executed, and that don't
require MSVC headers or libraries to be available.

(These tests already implicitly assumed to be built for x86; one
didn't specify anything, assuming x86_64, while the other specified
--arch=32, which only picks the 32 bit variant of the default target
architecture).

Join two comment lines in disassembly.cpp, to keep row numbers
checked in the test unchanged.

This fixes running check-lldb on arm linux.

Previously when this was applied (in 95980409e6), it broke
macos buildbots, as they added "-isysroot <path>" to all %clang*
substitutions, and clang-cl didn't support that.

Reapplying it without further changes to this patch, after D69619
(9c73925226), because now, such extra parameters are added to
%clang_host*, but not to plain %clang_cl.

Differential Revision: https://reviews.llvm.org/D69031
lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp
lldb/test/Shell/SymbolFile/NativePDB/function-types-calling-conv.cpp