glsl: Size TCS->TES unsized arrays to gl_MaxPatchVertices for queries.
authorKenneth Graunke <kenneth@whitecape.org>
Tue, 25 Oct 2016 10:38:54 +0000 (03:38 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Thu, 27 Oct 2016 07:56:51 +0000 (00:56 -0700)
commit173558445dce26ce641faf260a17696221acf23d
treeb6528f2717611c3f3c7b21205d3c8333106b2481
parent34fd2ffed8c7acfe1b19247eb3b98c3e754680b2
glsl: Size TCS->TES unsized arrays to gl_MaxPatchVertices for queries.

SSO validation and other program interface queries want to see that
unsized (non-patch) TCS output/TES input arrays are implicitly sized
to gl_MaxPatchVertices.

By the time we create the program resource lists, we've sized the arrays
to their actual size.  (We try to create TCS output arrays to match the
output patch size right away, and at this point, we should have shrunk
TES input arrays.)  One option would be to keep them sized to
gl_MaxPatchVertices, and defer shrinking them.  But that's a big change,
and I don't think it's a good idea.

Instead, this patch introduces a new ir_variable flag which indicates
the variable is implicitly to gl_MaxPatchVertices.  Then, the linker
munges the types when creating the resource list, ignoring the size
in the IR's types.  Basically, lie about it for resource queries.
It's ugly, but I think it ought to work.

We probably could use var->data.implicit_sized_array for this, but
I opted for a separate bit to try and avoid convoluting the existing
SSBO handling.  They're similar in concept, but share none of the
same code...

Fixes:
ES31-CTS.core.tessellation_shader.single.xfb_captures_data_from_correct_stage
and the ES32-CTS and ESEXT-CTS variants.

v2: Add a comment (requested by Timothy, written by me).

Cc: mesa-stable@lists.freedesktop.org
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Timothy Arceri <timothy.arceri@collabora.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
src/compiler/glsl/ast_to_hir.cpp
src/compiler/glsl/ir.h
src/compiler/glsl/linker.cpp
src/compiler/glsl/lower_named_interface_blocks.cpp