drm/msm: Use drm_mode_init() for on-stack modes
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 7 Nov 2022 19:25:41 +0000 (21:25 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 11 Nov 2022 23:41:13 +0000 (01:41 +0200)
commit17309a4793e9eec966544d4013c5bd0b394f4d0d
treee47d5c65dfaa3839953702a9adc575dcb04bce86
parenta01befa0a281b504587166d0d02d178791ae60b4
drm/msm: Use drm_mode_init() for on-stack modes

Initialize on-stack modes with drm_mode_init() to guarantee
no stack garbage in the list head, or that we aren't copying
over another mode's list head.

Based on the following cocci script, with manual fixups:
@decl@
identifier M;
expression E;
@@
- struct drm_display_mode M = E;
+ struct drm_display_mode M;

@@
identifier decl.M;
expression decl.E;
statement S, S1;
@@
struct drm_display_mode M;
... when != S
+ drm_mode_init(&M, &E);
+
S1

@@
expression decl.E;
@@
- &*E
+ E

Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221107192545.9896-4-ville.syrjala@linux.intel.com
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c