iio: adc: stmpe-adc: Shuffle an if statement around in stmpe_adc_isr
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 7 Mar 2019 17:16:04 +0000 (10:16 -0700)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 4 Apr 2019 19:19:56 +0000 (20:19 +0100)
commit17104ca2713ba443f9a02a7c4090514ad1e46ee9
tree136d463532cf6ba9c19b2e9d6ccc7c2139af12d9
parent6f9ca1d3eb74b81f811a87002de2d51640d135b1
iio: adc: stmpe-adc: Shuffle an if statement around in stmpe_adc_isr

When building with -Wsometimes-uninitialized, Clang warns:

drivers/iio/adc/stmpe-adc.c:204:13: warning: variable 'data' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Clang can't tell that data will never be used uninitialized because the
two if statements take care of all cases. Remove the first if statement
and make it the else branch of the second one so that it is apparent to
Clang that all cases are covered.

Link: https://github.com/ClangBuiltLinux/linux/issues/387
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: NIck Desaulniers <ndesaulniers@google.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/stmpe-adc.c