usb: dwc2: host: Avoid use of chan->qh after qh freed
authorDouglas Anderson <dianders@chromium.org>
Fri, 29 Jan 2016 02:19:55 +0000 (18:19 -0800)
committerFelipe Balbi <balbi@kernel.org>
Fri, 4 Mar 2016 13:14:40 +0000 (15:14 +0200)
commit16e80218816488f016418717d23c660abe073a67
tree74dd155a1274bbc7eace92a76e7907c19d7ffddd
parent098c1ef8fe6bcdfed7905cea1debdd3a0ff9a16f
usb: dwc2: host: Avoid use of chan->qh after qh freed

When poking around with USB devices with slub_debug enabled, I found
another obvious use after free.  Turns out that in dwc2_hc_n_intr() I
was in a state when the contents of chan->qh was filled with 0x6b,
indicating that chan->qh was freed but chan still had a reference to
it.

Let's make sure that whenever we free qh we also make sure we remove a
reference from its channel.

The bug fixed here doesn't appear to be new--I believe I just got lucky
and happened to see it while stress testing.

Acked-by: John Youn <johnyoun@synopsys.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/dwc2/hcd.c
drivers/usb/dwc2/hcd_intr.c