[TargetList] Simplify dummy target creation
authorVedant Kumar <vsk@apple.com>
Thu, 5 Nov 2020 19:38:50 +0000 (11:38 -0800)
committerVedant Kumar <vsk@apple.com>
Fri, 6 Nov 2020 00:04:02 +0000 (16:04 -0800)
commit16e5a347e70b4c819ff440dddd2320457cc2c8ca
treeaedd67a68418a1e305ab49173aca5bbe7714ccd6
parent3790e17f461e5de60e6f802497d96b7de036e0b2
[TargetList] Simplify dummy target creation

Factor out dummy target creation from CreateTargetInternal.

This makes it impossible for dummy target creation to accidentally fail
due to too-strict checking in one of the CreateTargetInternal overloads.

Testing: check-lldb

rdar://70630655

Differential Revision: https://reviews.llvm.org/D90872
lldb/include/lldb/Target/Target.h
lldb/include/lldb/Target/TargetList.h
lldb/source/Core/Debugger.cpp
lldb/source/Target/TargetList.cpp