udf: Discard preallocation before extending file with a hole
authorJan Kara <jack@suse.cz>
Wed, 7 Dec 2022 17:17:34 +0000 (18:17 +0100)
committerJan Kara <jack@suse.cz>
Fri, 9 Dec 2022 11:37:26 +0000 (12:37 +0100)
commit16d0556568148bdcaa45d077cac9f8f7077cf70a
tree3ef3ab16d7fc9db9c588b4a2520fdcbc25ba1720
parent6ad53f0f71c52871202a7bf096feb2c59db33fc5
udf: Discard preallocation before extending file with a hole

When extending file with a hole, we tried to preserve existing
preallocation for the file. However that is not very useful and
complicates code because the previous extent may need to be rounded to
block boundary as well (which we forgot to do thus causing data
corruption for sequence like:

xfs_io -f -c "pwrite 0x75e63 11008" -c "truncate 0x7b24b" \
  -c "truncate 0xabaa3" -c "pwrite 0xac70b 22954" \
  -c "pwrite 0x93a43 11358" -c "pwrite 0xb8e65 52211" file

with 512-byte block size. Just discard preallocation before extending
file to simplify things and also fix this data corruption.

CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
fs/udf/inode.c