ALSA: emu10k1: remove pointless locks from timer code
authorOswald Buddenhagen <oswald.buddenhagen@gmx.de>
Fri, 28 Apr 2023 09:59:36 +0000 (11:59 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 8 May 2023 07:20:48 +0000 (09:20 +0200)
commit16cafbd97759ba66c79bdede4250074f026839f3
tree35013060eda93c05dd9bf10c5011a4a3f1b0e595
parentac9a78681b921877518763ba0e89202254349d1b
ALSA: emu10k1: remove pointless locks from timer code

Contrary to its name, reg_lock locks the emu data structure, not the
registers. As the functions access only data which is set once at card
initialization, there is no point in locking it.

Actually locking the registers would be pointless as well, as
snd_emu10k1_intr_{en,dis}able() does its own locking, and TIMER is
accessed only in this one place.

Locking snd_emu10k1_timer_{start,stop}() against each other also
wouldn't buy us anything; the functions interleaving their I/O accesses
wouldn't introduce new problems.

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Link: https://lore.kernel.org/r/20230428095941.1706278-2-oswald.buddenhagen@gmx.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/emu10k1/timer.c