projects / platform / upstream / gst-plugins-base.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d4c1b16) | patch
libvisual: fix crashes and invalid writes in totem
authorTim-Philipp Müller <tim@centricular.net>
Sat, 8 Sep 2012 21:56:56 +0000 (22:56 +0100)
committerTim-Philipp Müller <tim@centricular.net>
Sat, 8 Sep 2012 22:03:16 +0000 (23:03 +0100)
commit16c185bac6ca543acdbb65562c738195f986b4d7
treefb0210ddeccb5cef21828c3771ef865136e72de6tree | snapshot
parentd4c1b160ef2efa037eaed203e3d73ba5a86e3cd2commit | diff
libvisual: fix crashes and invalid writes in totem

This reverts part of "visual: enable commented out code again."
(commit 8222ba16c8f671dc03e24e7b60e3e703046e58c1).

The shader code does indeed look broken (or rather,
it makes assumptions that are not necessarily true here,
namly that pixel stride is 4, for example), which
makes totem very crashy and causes other weird behaviour.

Also see https://bugzilla.gnome.org/show_bug.cgi?id=683527
ext/libvisual/gstaudiovisualizer.c diff | blob | history
Domain: Multimedia / Media Common;