Add AllowMultiple=true to QueryPropertyAttribute (#5180)
authorMatthew Robbins <matthew.ch.robbins@gmail.com>
Wed, 13 Feb 2019 12:43:51 +0000 (23:43 +1100)
committerRui Marinho <me@ruimarinho.net>
Wed, 13 Feb 2019 12:43:51 +0000 (12:43 +0000)
commit169daca254a8191477326b95f2dca717e9f216e7
tree3a1bdb3c7d2e8843dc3379ec69c9990a46beddf4
parent8747919ae5650de72c44004ef3722802609bf564
Add AllowMultiple=true to QueryPropertyAttribute (#5180)

In the process of building a demo app (https://github.com/matthewrdev/xamarin-forms-4), I discovered that I could not apply multiple parameters; doing so would cause a compile-time error.

The usage of this property in ShellContent, specifically in ApplyQueryAttributes, indicates that the intended behaviour is to allow users to specify multiple URL arguments that will be applied onto the page. Changing AllowMultiple to true fixes this.

For reference, when AllowMultiple is not explicitly set, it's default value is false. See: https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/concepts/attributes/attributeusage.
Xamarin.Forms.Core/Shell/QueryPropertyAttribute.cs