misc: pci_endpoint_test: Do not write status in IRQ handler
authorDamien Le Moal <dlemoal@kernel.org>
Sat, 15 Apr 2023 02:35:41 +0000 (11:35 +0900)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 23 Jun 2023 20:03:53 +0000 (15:03 -0500)
commit168e6f62e4298815125591ff9c85d374b2a93c6c
tree9ebddddfedce223ac8d554cd7526de8c3e1fc564
parentfb620ae73b70c2f57b9d3e911fc24c024ba2324f
misc: pci_endpoint_test: Do not write status in IRQ handler

pci_endpoint_test_irqhandler() always rewrites the status register when an
IRQ is raised, either as-is if STATUS_IRQ_RAISED is not set, or with
STATUS_IRQ_RAISED cleared if that flag is set. The first case creates a
race window with the endpoint side, meaning that the host side test driver
may end up reading what it just wrote, thus losing the real status as set
by the endpoint side before raising the next interrupt.  This can prevent
detecting that the STATUS_IRQ_RAISED flag was set by the endpoint.

Remove this race window by not clearing the STATUS_IRQ_RAISED status flag
and not rewriting that register for every IRQ received.

Link: https://lore.kernel.org/r/20230415023542.77601-17-dlemoal@kernel.org
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
drivers/misc/pci_endpoint_test.c