Revert "gstvalue: Avoid expensive fallback on intersection"
authorMatthew Waters <matthew@centricular.com>
Tue, 21 Apr 2020 09:33:08 +0000 (19:33 +1000)
committerGStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Wed, 22 Apr 2020 15:18:50 +0000 (15:18 +0000)
commit166c0fbc47541b15b78165327092334e2c0548d2
tree3d7ca9832dede4ea690b500e6e3f6d4bda867273
parent684723d07cb1bdbb0a64792109aae6b792629a93
Revert "gstvalue: Avoid expensive fallback on intersection"

This reverts commit cd751c2de39969ab6187eab12e4e8a85e0467cf7.
Reverts https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/406

Fixes glviewconvert negotiation in e.g.:

gltestsrc ! glviewconvert output-mode-override=side-by-side ! glstereosplit name=s s.left ! queue ! fakesink s.right ! queue ! glimagesink

Problem here is that intersecting flagsets in gst_value_intersect will
always find a value comparison function but may fail a direct type
comparison due to flagsets supporting derived types.  When flagset
derived types are intersected, an intersection will therefore always
fail.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/441>
gst/gstvalue.c