Revert "clutter-cairo-texture: Use the new cogl_pixel_buffer API"
authorNeil Roberts <neil@linux.intel.com>
Mon, 10 May 2010 14:33:05 +0000 (15:33 +0100)
committerNeil Roberts <neil@linux.intel.com>
Mon, 10 May 2010 15:17:32 +0000 (16:17 +0100)
commit16680c74f36d64b3fb9e1e3f3985c7e757dafdf3
treeb9bbbbd764c7b9f2d68c0d423013494d8e8bcc2a
parentaf37a1029ff86d082b55cebef6f59d227ab22da8
Revert "clutter-cairo-texture: Use the new cogl_pixel_buffer API"

This reverts commit 716ec82db8bec57e35d51e8dee5468435fc9e59e.

The Cogl pixel buffer API currently has problems if an atlas texture
is created or the format needs to be converted. The atlas problem
doesn't currently show because the atlas rejects BGR textures anyway
but we may want to change this soon. The problem with format
conversion would happen under GLES because that does not support BGR
textures at all so Cogl has to do the conversion. However it doesn't
currently show either because GLES has no support for buffer objects
anyway.

It's also questionable whether the patch would give any performance
benefit because Cairo needs read/write access which implies the buffer
can't be put in write-optimised memory.

Conflicts:

clutter/clutter-cairo-texture.c

http://bugzilla.openedhand.com/show_bug.cgi?id=1982
clutter/clutter-cairo-texture.c